Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-1348

PR (1324): (maint) Clean up BoneCP resources when finished - rbrw

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 3.0.0
    • Component/s: None
    • Labels:
    • Template:
    • Story Points:
      0
    • Sprint:
      PuppetDB 2015-04-08, PuppetDB 2015-04-22

      Description

      (maint) Clean up BoneCP resources when finished

      Pull Request Description


      Close the BoneCPDataSource when finished, freeing its threads (among
      possibly other things). Doing so substantially decreases the active
      thread count at for the end of "lein test", which can be demonstrated by
      adding this to the top of a test file before a run:

      (defmethod report :begin-test-var [m]
      (binding [*out* *err*]
      (prn (:var m) :active-threads (Thread/activeCount))))

      These changes should also affect normal invocations of "services -c ...".

      src/puppetlabs/puppetdb/cli/services.clj | 28 ++++++++++++++--------------
      test/puppetlabs/puppetdb/http/facts_test.clj | 3 ++-
      2 files changed, 16 insertions, 15 deletions


      (webhooks-id: 57868cafae2f052f35c145307ab1c977)

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                rob.browning Rob Browning
                Reporter:
                gepetto-bot gepetto-bot
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: