Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-1550

PR (1422): (maint) don't activate the node when it's already active - wkalt

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 2.3.5
    • Component/s: None
    • Labels:
    • Template:
    • Story Points:
      1
    • Sprint:
      PuppetDB 2015-06-03

      Description

      rt(maint) don't activate the node when it's already active

      Pull Request Description


      Before this commit we were updating the deactivated column of certnames to null
      even if it was already null. This caused unnecessary contention on the certnames
      table with each command submission, causing more frequent retries than needed.

      Also corrects the corresponding test logic: if nothing happens, then no records
      are updated, and the result of maybe-activate-node should not be positive.


      (webhooks-id: adcb919078716d7283f7ff7fc231f097)

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                gepetto-bot gepetto-bot
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: