Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-2441

Commands should be submitted only as bytes

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 4.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      2
    • Sprint:
      PuppetDB 2016-02-24

      Description

      Our code currently has a protocol that submits messages using TextMessages (if a string) and bytes message if it's a byte array. We should switch that to only submit byte messages. If given a string, we should just convert it to bytes.

      We should confirm this, but we've seen in heap dumps that the original bytes of the TextMessage remain in memory for the duration of the consumer thread's processing, in addition to the string copy. These bytes can be parsed directly and we can avoid having 2 copies in memory before being parsed.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                rob.browning Rob Browning
                Reporter:
                ryan.senior Ryan Senior
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: