Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-307

A change in rubygem 'mocha 1.0.0' has started causing rspec test failures

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PDB 1.5.0
    • Fix Version/s: PDB 1.6.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      20140108 to 20140115, 20140115 to 20140122

      Description

      So it seems that the change from mocha '0.14.0' to '1.0.0' has caused a new rspec test failure:

      Failures:
       
        1) Puppet::Reports::Puppetdb#report_to_hash should include the transaction uuid or nil
           Failure/Error: if subject.report_format >= 4
           NoMethodError:
             private method `report_format' called for #<Puppet::Transaction::Report:0x007fbe3d8d16b8>
           # ./spec/unit/reports/puppetdb_spec.rb:78:in `block (3 levels) in <top (required)>'
       
        2) Puppet::Reports::Puppetdb#report_to_hash events resource with events should include the resource
           Failure/Error: if subject.report_format >= 4
           NoMethodError:
             private method `report_format' called for #<Puppet::Transaction::Report:0x007fbe3c906698>
           # ./spec/unit/reports/puppetdb_spec.rb:145:in `block (5 levels) in <top (required)>'
       
      Finished in 0.72031 seconds
      117 examples, 2 failures
      

      This applies to all branches: 1.5.x, 1.6.x and master.

      Unfortunately our rspec tests in jenkins have not been picking this up, because 'bundle update' never gets ran so we never see it there.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ken Ken Barber
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support