Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-3281

(MAINT) Close datasource in max connection jdbc pool tests

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 4.4.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • QA Risk Assessment:
      Needs Assessment

      Description

      Previously, the max connections jdbc pool-construction tests did not
      close the connection pool data source before falling out of scope.
      Depending upon timing, this could cause the tests to fail on
      attempting to drop temp databases which are still busy being used
      by the connection pool.

      This commit wraps usage of the data source in each of the max
      connections tests with `with-open` calls, allowing the connection pool
      to be closed off before any calls to drop the temporary databases occur
      (and, therefore, for the tests to complete successfully).

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              gepetto-bot gepetto-bot
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support