Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-3505

(maint) Use a real scope object for terminus testing

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 4.4.1, PDB 5.0.0
    • Component/s: None
    • Labels:
    • Template:
    • Team:
      Systems Engineering
    • Story Points:
      1
    • Sprint:
      PuppetDB 2017-05-31
    • Release Notes:
      Not Needed
    • QA Risk Assessment:
      Needs Assessment

      Description

      Changes coming in Puppet 5.0.0 change how Puppet::Parser::Resource
      instances set default values; in specific they do so upon object
      construction which requires a functioning(ish) scope object. The
      Puppetdb terminus specs were relying on the scope object being
      relatively simple and easily stubbed but this change in defaults makes
      it much harder to treat the scope object as an easily stubbed object.

      To simplify stubbing and potentially reduce future breakage this commit
      changes the scope stubbing to partially stub a full scope object instead
      of creating a pure stub object and adding methods as necessary. By using
      a full scope object we can let the internal APIs of Puppet handle
      implementation changes.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  adrien Adrien Thebo
                  Reporter:
                  gepetto-bot gepetto-bot
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: