Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-3541

Fix shutdown hang on on flush-and-exit (at least for db ver check)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 4.4.1, PDB 5.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Data Platform
    • Story Points:
      2
    • Sprint:
      Hopper/Triage
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      (Might belong alongside the documentation of the postgresql 9.6 requirement.)

      PuppetDB should now shut down with a non-zero exit status when it detects an unsupported PostgreSQL version. Previously it might hang while trying to exit.
      Show
      (Might belong alongside the documentation of the postgresql 9.6 requirement.) PuppetDB should now shut down with a non-zero exit status when it detects an unsupported PostgreSQL version. Previously it might hang while trying to exit.
    • QA Risk Assessment:
      Needs Assessment

      Description

      I haven't tracked down the hang yet, but I at the moment, I suspect it's because we're not calling close on the pdb service. I need to go double-check just how System/exit interacts with daemon and non-daemon threads.

      As a "cleaner" alternative, I've also tried using tk's request-shutdown, and that seems promising, but it causes new exceptions when close fails on unexpected nils. We might want to use tk's shutdown-on-error. It'll produce an unwanted backtrace, but might be the only way to shutdown "normally" for now with a non-zero exit status.

        Attachments

          Activity

            People

            Assignee:
            rob.browning Rob Browning
            Reporter:
            rob.browning Rob Browning
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support