Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-463

Assertion failure for v1 resource queries after upgrading to 1.6.x

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PDB 1.6.2
    • Fix Version/s: PDB 1.6.3
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      20140212 to 20140219

      Description

      We just upgraded to 1.6.2 from 1.5.0.
      Our v1 resource queries stopped working with the following exception:

      java.lang.AssertionError: Assert failed: (and (integer? limit) (>= limit 0))
      at com.puppetlabs.puppetdb.http.v1.resources$produce_body.invoke(resources.clj:86)
      at com.puppetlabs.puppetdb.http.v1.resources$routes$fn_6411$fn_6416.invoke(resources.clj:119)
      at com.puppetlabs.puppetdb.http.v1.resources$routes$fn__6411.invoke(resources.clj:113)
      at com.puppetlabs.puppetdb.http.v1.resources$routes.invoke(resources.clj:113)
      at com.puppetlabs.middleware$verify_accepts_content_type$fn__5903.invoke(middleware.clj:104)
      at com.puppetlabs.middleware$validate_query_params$fn__5908.invoke(middleware.clj:131)
      at com.puppetlabs.puppetdb.http.v1$v1_app$fn__6801.invoke(v1.clj:12)
      at net.cgrand.moustache$alter_request$fn__6156.invoke(moustache.clj:54)
      at com.puppetlabs.puppetdb.http.v1$v1_app.invoke(v1.clj:12)
      at com.puppetlabs.puppetdb.http.server$deprecated_app.invoke(server.clj:22)
      at com.puppetlabs.puppetdb.http.server$deprecated_v1_app.invoke(server.clj:35)
      at com.puppetlabs.puppetdb.http.server$routes$fn__9418.invoke(server.clj:41)
      at net.cgrand.moustache$alter_request$fn__6156.invoke(moustache.clj:54)
      at com.puppetlabs.puppetdb.http.server$routes.invoke(server.clj:41)
      at ring.middleware.resource$wrap_resource$fn__9397.invoke(resource.clj:17)
      at ring.middleware.params$wrap_params$fn__6098.invoke(params.clj:55)
      at com.puppetlabs.middleware$wrap_with_authorization$fn__5882.invoke(middleware.clj:37)
      at com.puppetlabs.middleware$wrap_with_certificate_cn$fn__5886.invoke(middleware.clj:52)
      at com.puppetlabs.middleware$wrap_with_default_body$fn__5890.invoke(middleware.clj:59)
      at com.puppetlabs.middleware$wrap_with_metrics_STAR_$fn_5924$fn_5933.invoke(middleware.clj:183)
      at com.puppetlabs.utils.metrics$multitime_BANG_STAR$fn_5861$fn5862$fn_5863.invoke(metrics.clj:14)
      at com.puppetlabs.utils.metrics.proxy$java.lang.Object$Callable$f8c5758f.call(Unknown Source)
      at com.yammer.metrics.core.Timer.time(Timer.java:91)
      at com.puppetlabs.utils.metrics$multitime_BANG_STAR$fn_5861$fn_5862.invoke(metrics.clj:14)
      at com.puppetlabs.utils.metrics$multitime_BANG_STAR$fn_5861$fn5862$fn_5863.invoke(metrics.clj:14)
      at com.puppetlabs.utils.metrics.proxy$java.lang.Object$Callable$f8c5758f.call(Unknown Source)
      at com.yammer.metrics.core.Timer.time(Timer.java:91)
      at com.puppetlabs.utils.metrics$multitime_BANG_STAR$fn_5861$fn_5862.invoke(metrics.clj:14)
      at com.puppetlabs.utils.metrics$multitime_BANG_STAR.invoke(metrics.clj:17)
      at com.puppetlabs.middleware$wrap_with_metrics_STAR_$fn__5924.invoke(middleware.clj:182)
      at com.puppetlabs.middleware$wrap_with_globals$fn__5894.invoke(middleware.clj:70)
      at com.puppetlabs.middleware$wrap_with_debug_logging$fn__5878.invoke(middleware.clj:24)
      at ring.adapter.jetty$proxy_handler$fn__5781.invoke(jetty.clj:18)
      at ring.adapter.jetty.proxy$org.eclipse.jetty.server.handler.AbstractHandler$0.handle(Unknown Source)
      at org.eclipse.jetty.server.handler.GzipHandler.handle(GzipHandler.java:267)
      at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:111)
      at org.eclipse.jetty.server.Server.handle(Server.java:349)
      at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:452)
      at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:884)
      at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:938)
      at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:634)
      at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:230)
      at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:76)
      at org.eclipse.jetty.io.nio.SslConnection.handle(SslConnection.java:191)
      at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:609)
      at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:45)
      at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:599)
      at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:534)
      at java.lang.Thread.run(Thread.java:744)

      To reproduce, you can try the example query from the docs (http://docs.puppetlabs.com/puppetdb/1.6/api/query/v3/resources.html), as it produces the same results.

        Activity

        Hide
        ken Ken Barber added a comment -
        Show
        ken Ken Barber added a comment - PR is here: https://github.com/puppetlabs/puppetdb/pull/860
        Hide
        imriz Imri Zvik added a comment -

        The fix does make the exception go away, but it returns empty results on all queries.

        Show
        imriz Imri Zvik added a comment - The fix does make the exception go away, but it returns empty results on all queries.
        Hide
        ken Ken Barber added a comment -

        Imri Zvik this is fixed now with my latest commit.

        Show
        ken Ken Barber added a comment - Imri Zvik this is fixed now with my latest commit.
        Hide
        ken Ken Barber added a comment -

        1.6.3 has now been released with this fix.

        Show
        ken Ken Barber added a comment - 1.6.3 has now been released with this fix.

          People

          • Assignee:
            Unassigned
            Reporter:
            imriz Imri Zvik
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile