Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-4974

Wait on schedulers to shut down

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 6.14.0, PDB 7.1.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      HA
    • Story Points:
      3
    • Sprint:
      HA 2021-01-27, HA 2021-02-10
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Previously an attempt to stop (or restart) PuppetDB might appear to succeed, even though some of its components were actually still running. That's because PuppetDB wasn't actually waiting for some of the internal tasks to finish as had been expected. Now PuppetDB should block during stop or restart until all of the components have actually shut down. This issue is a likely contributor to some cases where PuppetDB appeared to restart/reload successfully, but sync never started working again.
      Show
      Previously an attempt to stop (or restart) PuppetDB might appear to succeed, even though some of its components were actually still running. That's because PuppetDB wasn't actually waiting for some of the internal tasks to finish as had been expected. Now PuppetDB should block during stop or restart until all of the components have actually shut down. This issue is a likely contributor to some cases where PuppetDB appeared to restart/reload successfully, but sync never started working again.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Although we'd expected to be waiting for our schedulers (at-at pools) to stop before returning from our start/stop methods, we weren't because at-at runs the relevant ScheduledThreadPoolExecutor shutdown function in a future and returns immediately.

       

        Attachments

        1. icon.png
          icon.png
          1 kB
        2. icon.png
          icon.png
          1 kB

          Issue Links

            Activity

              People

              Assignee:
              rob.browning Rob Browning
              Reporter:
              rob.browning Rob Browning
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support