Uploaded image for project: 'PuppetDB'
  1. PuppetDB
  2. PDB-5131

Enable drop joins by default

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDB 7.5.0
    • Component/s: None
    • Labels:
    • Template:
    • Acceptance Criteria:
      • Drop joins is enabled by default for `"from" "nodes"` queries
      • Drop joins can be disabled
    • Team:
      HA
    • Story Points:
      1
    • Sprint:
      HA 2021-06-02, HA 2021-07-14
    • Release Notes:
      Enhancement
    • Release Notes Summary:
      Hide
      The query optimizer https://puppet.com/docs/puppetdb/latest/api/query/v4/query.html#experimental-query-optimization that attempts to drop unneeded joins is now enabled by default, but that can be changed by setting the PDB_QUERY_OPTIMIZE_DROP_UNUSED_JOINS environment variable.
      Show
      The query optimizer https://puppet.com/docs/puppetdb/latest/api/query/v4/query.html#experimental-query-optimization that attempts to drop unneeded joins is now enabled by default, but that can be changed by setting the PDB_QUERY_OPTIMIZE_DROP_UNUSED_JOINS environment variable.
    • QA Risk Assessment:
      Needs Assessment

      Description

      Drop joins has shown that it can significantly speed up nodes queries, so we should enable it by default for that entity. We should test that drop joins can be disabled, so that users can back out of this change if they encounter errors. Initially this will target main so that 6.x will be more stable. If it proves stable, we may backport it later.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rob.browning Rob Browning
              Reporter:
              austin.blatt Austin Blatt
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support