Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1032

Fix multi-spinner display when doing parallel batched validation

    Details

    • Type: Bug
    • Status: Accepted
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Puppet Developer Experience
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      Needs Assessment

      Description

      From PDK-985

      There seem to be some issues with how the new code interacts with the multispinner:
       
      $ lpdk validate --parallel
      pdk (INFO): Running all available validators...
      pdk (INFO): Using Ruby 2.4.4
      pdk (INFO): Using Puppet 5.5.1
      ┌ [✔] Validating module using 3 threads        ┌
      └──[✔] Checking metadata syntax (metadata.json ┌ ─ks/*.json).
      └──[/] Checking module metadata style (metadata├──on).
      └──[✔] Checking module metadata style (metadata├──on).
      └──[✔] Checking task metadata style (tasks/*.json).
      [✔] Checking Puppet manifest syntax (**/**.pp).
      [✔] Checking Puppet manifest style (**/*.pp).
      convention: rubocop: spec/unit/puppet/provider/testprovider/testprovider_spec.rb:4:1: Style/Documentation: Missing top-level module documentation comment.
      vs master:
       
      pdk (INFO): Running all available validators...
      pdk (INFO): Using Ruby 2.4.4
      pdk (INFO): Using Puppet 5.5.1
      ┌ [✖] Validating module using 3 threads
      ├──[✖] Checking Ruby code style (**/**.rb).
      ├──[✔] Checking metadata syntax (metadata.json tasks/*.json).
      ├──[✔] Checking Puppet manifest syntax (**/**.pp).
      ├──[✔] Checking module metadata style (metadata.json).
      ├──[✔] Checking task metadata style (tasks/*.json).
      └──[✔] Checking Puppet manifest style (**/*.pp).
      convention: rubocop: spec/unit/puppet/provider/testprovider/testprovider_spec.rb:4:1: Style/Documentation: Missing top-level module documentation comment.
      I'm going to see if I can figure out what is going on.
      

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  bryan.jen Bryan Jen
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated: