Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1211

PDK update/convert ignore's .gitattribute file

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PDK 1.8.0
    • None
    • PDK 1.7.1

    • Needs Assessment
    • Bug Fix
    • Fixes an issue where the .gitattributes file was not being managed by PDK.
    • Needs Assessment

    Description

      I was reviewing a PR for apt when I noticed that it was for the .gitattributes file which, to my knowledge, should have been managed by the PDK.
      Upon examining the file I noticed that it also contained the managed by ModuleSync message at the top of it that should have been automatically stripped out when we swapped over.
      I then altered the .gitattribute file of my local copy of stdlib and ran PDK update to see what would happen only for my change to be ignored. I repeated my experiment with the PDK convert command and a local copy of apt.

      Attachments

        Activity

          People

            tim.sharpe Tim Sharpe
            david.swan David Swan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support