Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1337

PDK should not be impacted by externally declared PUPPET_GEM_VERSION

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PDK 1.9.1
    • Fix Version/s: PDK 1.11.0
    • Component/s: None
    • Template:
    • Acceptance Criteria:
      Hide
      • externally declared PUPPET_GEM_VERSION (and related) environment variables should be unset for any PDK-invoked subprocesses, even if the user hasn't requested a specific version with --puppet-version or --pe-version
      • log a warning that PUPPET_GEM_VERSION is being ignored (use PDK_GEM_VERSION instead)
      Show
      externally declared PUPPET_GEM_VERSION (and related) environment variables should be unset for any PDK-invoked subprocesses, even if the user hasn't requested a specific version with --puppet-version or --pe-version log a warning that PUPPET_GEM_VERSION is being ignored (use PDK_GEM_VERSION instead)
    • Team:
      Puppet Developer Experience
    • Method Found:
      Customer Feedback
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      PDK will now warn the user if they try to use PUPPET_GEM_VERSION, FACTER_GEM_VERSION or HIERA_GEM_VERSION environment variables and unset them so that they do not affect the PDK command. In the case of PUPPET_GEM_VERSION, the warning from PDK will suggest that the user use the --puppet-version option or PDK_PUPPET_VERSION environment variable instead.
      Show
      PDK will now warn the user if they try to use PUPPET_GEM_VERSION, FACTER_GEM_VERSION or HIERA_GEM_VERSION environment variables and unset them so that they do not affect the PDK command. In the case of PUPPET_GEM_VERSION, the warning from PDK will suggest that the user use the --puppet-version option or PDK_PUPPET_VERSION environment variable instead.
    • QA Risk Assessment:
      Needs Assessment

      Description

      If the user manually exports a "PUPPET_GEM_VERSION" variable before invoking PDK, it should have no impact on PDK or its subprocesses.

      rpcbind$ export PUPPET_GEM_VERSION=6.3.0
      rpcbind$ pdk test unit
      pdk (INFO): Using Ruby 2.5.3
      pdk (INFO): Using Puppet 6.2.0
      [✔] Installing missing Gemfile dependencies.
      pdk (FATAL): Failed to generate binstubs for 'rake rspec-core':
      You have requested:
        puppet = 6.3.0
       
      The bundle currently has puppet locked at 6.2.0.
      Try running `bundle update puppet`
       
      If you are updating multiple gems in your Gemfile at once,
      try passing them all to `bundle update`
       
       
      pdk (FATAL): Unable to install requested binstubs.

      See also: https://github.com/puppetlabs/pdk/issues/635

        Attachments

          Activity

            People

            Assignee:
            tim.sharpe Tim Sharpe
            Reporter:
            jesse Jesse Scott
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support