Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1354

Default template-ref for custom template-url's should be "master"

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • PDK 1.10.0
    • PDK 1.11.0
    • None
      • Your PDK installation method (native packages or via Rubygems): RHEL 7 RPM
      • Your PDK version (pdk --version): 1.10.0
      • Your operating system / platform: CentOS 7.5 x86_64
    • Puppet Developer Experience
    • Customer Feedback
    • Bug Fix
    • When running PDK from a packaged install, the default template-ref when a user has specified a custom template-url will be "master" rather than the default version of the packaged template.
    • Needs Assessment

    Description

      https://github.com/puppetlabs/pdk/issues/659

      Prior to PDK 1.10.0, specifying a custom template repository URL resulted in fetching the {{master}}branch of the template repository. PDK 1.10.0 now defaults to a branch matching the PDK version.

      To Reproduce
      $ pdk new module --template-url ssh://git@github.com/user/puppet-pdk-templates.git pdk (ERROR): Unable to find a branch or tag named "1.10.0" in file:///tmp/pdk-templates20190424-27149-5neu5c
      Or using an answers.json:

      { "template-url": "ssh://git@github.com/user/puppet-pdk-templates.git" }

      $ pdk new module pdk (ERROR): Unable to find a branch or tag named "1.10.0" in file:///tmp/pdk-templates20190424-31082-1ib182g
      Expected behavior
      New module is created using the master branch of the template repository without having to specify --template-ref master as in previous versions.

      Attachments

        Activity

          People

            tim.sharpe Tim Sharpe
            jesse Jesse Scott
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support