Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1363

Converting a module should apply with moduleroot_init templates

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDK 1.13.0
    • Component/s: None
    • Template:
    • Acceptance Criteria:
      Hide
      • Running `pdk convert` on a module will create/modify files from the templates in `moduleroot_init` unless they have been explicitly unmanaged in .sync.yml
      • Running `pdk update` continues to not manage the `moduleroot_init` files.
      Show
      Running `pdk convert` on a module will create/modify files from the templates in `moduleroot_init` unless they have been explicitly unmanaged in .sync.yml Running `pdk update` continues to not manage the `moduleroot_init` files.
    • Team:
      Puppet Developer Experience
    • Release Notes:
      Enhancement
    • Release Notes Summary:
      `pdk convert` will now create any missing init-only templated files (from the moduleroot_init folder in the template) like README.md.
    • QA Risk Assessment:
      Needs Assessment

      Description

      (Import from GH issue #547)

      PDK moduleroot_init templates are only added to a module during creation (pdk new). There is currently no mechanism to get these templates added to an existing module. Perhaps they could be processed and added during convert/update if they don't already exist in the module? A simpler, less elegant solution would be to just add an 'init' flag to update/convert.

      We should definitely be applying the moduleroot_init templates when converting a module, but not when updating

        Attachments

          Activity

            People

            Assignee:
            tim.sharpe Tim Sharpe
            Reporter:
            tim.sharpe Tim Sharpe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support