Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1378

PDK vendored Git should use system /etc/gitconfig

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • None
    • PDK 1.11.0
    • None
      • Vendored git binary looks for --system level config at /etc/gitconfig
    • Puppet Developer Experience
    • Bug Fix
    • PDK's embedded git will now read the standard locations for `gitconfig` files on non-Windows platforms (e.g. /etc/gitconfig, $HOME/.gitconfig).
    • Needs Assessment

    Description

      Currently the PDK vendored Git binary on non-Windows platforms looks for a system level gitconfig at /opt/puppetlabs/pdk/private/git/etc/gitconfig instead of /etc/gitconfig.

      This is due to the default value of sysconfdir being relative path when Git is compiled with a prefix: https://github.com/git/git/blob/master/Makefile#L1208-L1214

      I think we should update our builds to look for /etc/gitconfig instead so that we automatically pick up any custom proxy or SSL config that has been configured at the system level.

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. PDK-1388 Make whether or not to use system-provided git a configurable option

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Accepted

          Activity

            People

              jesse Jesse Scott
              jesse Jesse Scott
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support