Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1439

PDK 1.11 does runs rubocop even when disabled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDK 1.14.0
    • Component/s: None
    • Template:
    • Acceptance Criteria:
      Hide

      No rubocop validation takes place when using "off" profile.

      Show
      No rubocop validation takes place when using "off" profile.
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      `pdk validate` will no longer continue to run rubocop-i18n checks when the Rubocop profile is set to "off"
    • QA Risk Assessment:
      Needs Assessment

      Description

      Disabling rubocop in .sync.yml:

          .rubocop.yml:

            selected_profile: off

       

      But one rubocop validation is still running: 

      GetText/DecorateFunctionMessage: 'raise' function, message should use correctly formatted interpolation.

       

        Attachments

          Activity

            People

            Assignee:
            glenn.sarti Glenn Sarti
            Reporter:
            malfke Martin Alfke
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support