Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-1461

Regex for changelog_project incomplete and docs are wrong

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDK 1.13.0
    • Component/s: None
    • Labels:
    • Template:
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      Needs Assessment

      Description

      While using PDK version 1.12.0 today I found two related issues:

      1. the docs claim that the default value for changelog_project comes from the name attribute in metadata.json... it actually comes from parsing the source attribute.
      2. the regex used to parse the source attribute to generate the default for changelog_project did not account for a url ending in '.git'.

      A PR is forthcoming with a fix for this. Pinging Jesse Scott as he and I chatted a lot about this issue today.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              gene.liverman Gene Liverman
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support