Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-547

Files generated from PDK new module on Windows create with CRLF line endings


    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PDK 1.8.0
    • Component/s: None
    • Environment:

      PDK 1.1.10
      Windows 10

    • Template:
    • Acceptance Criteria:
      • Files which are expected to be LF in .gitattributes should have LF line endings on any OS
    • Method Found:
      Customer Feedback
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Files generated by PDK will no longer have CRLF line endings. They should all have LF line endings now.
    • QA Risk Assessment:
      Needs Assessment


      I created a new module using pdk new module ...

      and it generated all of the files using CRLF line endings. This caused git to complain because .rb files should be LF

      About to generate this module; continue? Yes
      pdk (INFO): Module 'windows_bitlocker' generated at path 'C:/Source/puppetlabs-windows_bitlocker/windows_bitlocker/windows_bitlocker'.
      pdk (INFO): In your module directory, add classes with the 'pdk new class' command.
      C:\Source\puppetlabs-windows_bitlocker\windows_bitlocker [master +15 ~0 -0 !]> git add --a
      warning: CRLF will be replaced by LF in spec/spec_helper.rb.
      The file will have its original line endings in your working directory.
      C:\Source\puppetlabs-windows_bitlocker\windows_bitlocker [master +16 ~0 -0 ~]>


          Issue Links



              • Assignee:
                tim.sharpe Tim Sharpe
                glenn.sarti Glenn Sarti
              • Votes:
                0 Vote for this issue
                1 Start watching this issue


                • Created:

                  Zendesk Support