Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Duplicate
-
None
-
None
-
None
-
None
-
-
Puppet Developer Experience
-
Needs Assessment
Description
There's been hints that lead towards there being a possible discrepancy between what the PDK runs during the 'validate' command, and the linting rules that are run on travis.
Travis config tells travis to run the rake task which pulls in the supported modules rules from spec helper - The rules defined in puppetlabs spec helper currently panders to a lot of special cases for modules, and going forward we want those special cases to be removed so we are consistent with lint across the board.
This sounds like it's possibly causing the validate command to pass, but when it comes to pushing a PR travis may fail on the additional cops ran.
Attachments
Issue Links
- blocks
-
PDK-786 Update pdk-templates travis and appveyor configs
-
- Closed
-
- is blocked by
-
PDK-1499 Audit Appveyor and Travis configurations for moving back to PDK-Templates
-
- Resolved
-
-
PDK-1500 Create pdk-templates for using Litmus
-
- Resolved
-
-
PDK-1501 Migrate some modules to templated CI for travis and appveyor
-
- Resolved
-
- is supported by
-
PDK-477 PDK in CI/CD systems
-
- Closed
-
- relates to
-
PDK-605 travis and appveyor configs should run task metadata validation
-
- Closed
-
- links to