Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-709

Update pdk-template CI configs to use PDK

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Accepted
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      Hide
      • PDK-1501 is complete
      • Move the work that was previously in a branch on pdk-templates back into master
      • Revert the template url/ref changes that were done in PDK-1501
      • Ticket the work to change the sync.yml files for all modules audited in PDK-1499
      Show
      PDK-1501 is complete Move the work that was previously in a branch on pdk-templates back into master Revert the template url/ref changes that were done in PDK-1501 Ticket the work to change the sync.yml files for all modules audited in PDK-1499
    • Team:
      Puppet Developer Experience
    • QA Risk Assessment:
      Needs Assessment

      Description

      There's been hints that lead towards there being a possible discrepancy between what the PDK runs during the 'validate' command, and the linting rules that are run on travis.

      Travis config tells travis to run the rake task which pulls in the supported modules rules from spec helper - The rules defined in puppetlabs spec helper currently panders to a lot of special cases for modules, and going forward we want those special cases to be removed so we are consistent with lint across the board.

      This sounds like it's possibly causing the validate command to pass, but when it comes to pushing a PR travis may fail on the additional cops ran.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              helen Helen Campbell
              Votes:
              4 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:

                  Zendesk Support