Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-709

Update travis-ci and appveyor config in templates to use PDK

    Details

    • Type: Bug
    • Status: Ready for Engineering
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      • Manually generate a module and pushing it to github. Ensure that travis-ci and appveyor run the same validations and unit test commands as `pdk validate` and `pdk test unit`.
    • Team:
      Puppet Developer Experience
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      Needs Assessment

      Description

      There's been hints that lead towards there being a possible discrepancy between what the PDK runs during the 'validate' command, and the linting rules that are run on travis.

      Travis config tells travis to run the rake task which pulls in the supported modules rules from spec helper - The rules defined in puppetlabs spec helper currently panders to a lot of special cases for modules, and going forward we want those special cases to be removed so we are consistent with lint across the board.

      This sounds like it's possibly causing the validate command to pass, but when it comes to pushing a PR travis may fail on the additional cops ran.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  bryan.jen Bryan Jen
                  Reporter:
                  helen Helen Campbell
                • Votes:
                  3 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated: