Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-903

Don't scan .git directory when building a module

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PDK 1.4.1, PDK 1.5.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      $ pdk --version
      1.4.1

    • Template:
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      Needs Assessment

      Description

      My module has a large git history. I've been running pdk build for many minutes now and it looks like pdk is scanning the entire .git and .bundle directories:

      stat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/098f01e1c989e8ed4a19a6493b23126867bf07\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/20672afcb38b7ff118a6c32cccd3e7c7165a81\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/20ca90ccc264fb3ee8a95bc68fec7cd6f6f7d1\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/23a063ecd1f0253e4c9daa2bb2480fde2ce08c\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/3642e8198184f7be391259209fe2a5fc6cc267\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/3b71edf467d49571fe55610237d1019e784970\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/4f9a962ff89d7d3a61aa306b529f652c9ab675\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/5154178843693ad60ab1f770b1d064f1f828e7\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/73806af6553c733f95a055a9cdeee546ca6a02\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/999042a7e363319e9caee74a3be02c6bef0365\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/9bb7a34c0ce2069dc9bfc3e49907cff3b07f56\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/a19aafd68f645baee2f03382230844fc6e7e8f\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/b0631c7add61d70b8066a95d6ad85563831af5\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/b4c71937e67603e7d15031eb51d2b0ba766059\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/bd2629f67fdb8340c91bc0f4601ce22d238b0c\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/d868dbe593f1a7dcffe3575622039405badc79\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/fa2b6f282300a0eac8a09ec0b802f52a1e25c6\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/fa4805a32a66a0c80fe00e4de9da23faa40a16\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/04/fd76f854ec983c2e29eabeaadf8cc094923304\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      lstat64("/Users/josh/work/modules/puppetlabs-zone/.git/objects/05\0", 0x7FFF56145E58, 0x1000)		 = 0 0
      open_nocancel("/Users/josh/work/modules/puppetlabs-zone/.git/objects/05\0", 0x1100004, 0x506805)		 = 7 0
      fstatfs64(0x7, 0x7FFF56145428, 0x506805)		 = 0 0
      fgetattrlist(0x7, 0x7FFF56145898, 0x7FFF561458B0)		 = 0 0
      getdirentries64(0x7, 0x7FF3FB024000, 0x1000)		 = 1264 0
      getdirentries64(0x7, 0x7FF3FB024000, 0x1000)		 = 0 0
      close_nocancel(0x7)		 = 0 0
      

      We should probably skip files in the .gitignore.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  josh Josh Cooper
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Zendesk Support