Uploaded image for project: 'Puppet Development Kit'
  1. Puppet Development Kit
  2. PDK-956

pdk should not enforce an empty array for dependencies if no dependencies are given

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Won't Do
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
    • Team:
      Puppet Developer Experience
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      Needs Assessment

      Description

      The Problem

      pdk makes a dependencies key in metadata.json no matter what. When given no dependencies it gives an empty array of dependencies.

      This shouldn't matter but it does because of PUP-6964 and because of that ticket it means that users that run `pdk convert` on an existing module without a dependencies key might end up with a module that doesn't work anymore because it can't find functions from other modules ( most notably stdlib ).

      Suggested Solution

      We should omit the dependencies key when none are given.

      Once PUP-6964 is resolved the original behavior can be restored.

      Customer impact

      Customers running `pdk convert` on an existing module with no dependencies may run into issues finding functions from other modules (most likely stdlib).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              nick.walker Nick Walker
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support