Uploaded image for project: 'Puppet Development Kit (moved to puppet.atlassian.net)'
  1. Puppet Development Kit (moved to puppet.atlassian.net)
  2. PDK-998

Cannot use rubocop profile "off" with pdk update

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PDK 1.6.0
    • None
    • Using PDK 1.5.0.0 from RPM on CentOS 7, pointed at the template-ref "heads/master-0-g7b5f6d2

    • Needs Assessment
    • Bug Fix
    • Fixed an issue preventing module developers from disabling rubocop checks via .sync.yml.
    • Needs Assessment

    Description

      It looks like I should be able to set a `selected_profile` of `off` in .sync.yml to disable rubocop, but that generates an error when using pdk update as it tries to loop through some empty hash for the profile.

      [rnelson0@build03 domain_join:pdk±]$ tail -2 .sync.yml
      .rubocop.yml:
        selected_profile: off
      [rnelson0@build03 domain_join:pdk±]$ pdk update
      pdk (FATAL): Failed to render template '.rubocop.yml.erb'
      NoMethodError: undefined method `keys' for []:Array
       

      Attachments

        Activity

          People

            david.schmitt David Schmitt
            rnelson0@gmail.com Rob Nelson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support