[PUP-10227] Close the http connection prior to sleeping retry-after seconds - Puppet Jira Server

XML

Word

Printable

Details

Type: Bug
Status: Resolved
Priority: Normal
Resolution: Fixed
Affects Version/s: None
Fix Version/s: PUP 5.5.19, PUP 6.13.0
Component/s: None
Labels:
- resolved-issue-added

Epic Link:
Agent HTTP
Team:
Coremunity
Sprint:
Platform Core KANBAN
Method Found:
Needs Assessment

Release Notes:
Enhancement
Release Notes Summary:

Hide
When puppetserver returns a 429 or 503 to an agent when the agent tries to make an http request, the agent run will sleep and then retry the connection after. Previously, the agent kept the http connection open during the sleep. We now close the connection prior to the sleep to reduce the resource load on the puppetserver.

Show
When puppetserver returns a 429 or 503 to an agent when the agent tries to make an http request, the agent run will sleep and then retry the connection after. Previously, the agent kept the http connection open during the sleep. We now close the connection prior to the sleep to reduce the resource load on the puppetserver.

QA Risk Assessment:
Needs Assessment

Description

To prevent thundering herds, puppetserver may return Retry-After and ask the agent to sleep. Until recently the agent would keep the connection open, until timeout occurs. To reduce resource usage on puppetserver, we should close the connection immediately.

The latest puppetserver version will return Connection: close, but agents may talk to older puppetservers versions which would benefit from this.

Attachments

Issue Links

relates to

SERVER-2696 503 responses sent when the JRuby pool is overloaded should include Connection: close headers

Resolved

Activity

People

Assignee:: Melissa Stone

Reporter:: Josh Cooper

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2020/01/08 1:56 PM

Updated:: 2020/05/13 6:18 PM

Resolved:: 2020/02/13 4:15 PM