Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10292

external trusted data is executed for file_content requests

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • PUP 6.12.0
    • PUP 6.16.0
    • None
    • Coremunity
    • Platform Core KANBAN
    • Needs Assessment
    • Enhancement
    • The `trusted_external_command` is only run once when external data is requested, rather than every time a request is made.
    • Needs Assessment

    Description

      Puppet Version: 6.12.0
      Puppet Server Version: 6.8.0
      OS Name/Version: RHEL

      When using the trusted_external_command setting, the command is executed for every file_content request, not just catalogs. This info can't possibly be required for a file_content request and this will cause a huge performance impact to the puppetserver as this could easily be executed 1000 times for a given node if it's new and needs to do a pluginsync, or if there are a lot of files managed.

      The error you see below is just from my trusted_external_command and is irrelevant other than show that it does execute it each time

       

      172.17.0.2 - - - 12/Feb/2020:11:52:37 +0000 "GET /puppet/v3/file_content/plugins/puppet/parser/functions/chomp.rb?environment=production& HTTP/1.1" 200 1295 172.17.0.2 172.17.0.2 8140 96
      2020-02-12 11:52:37,545 WARN  [c.p.p.ShellUtils] Executed an external process which logged to STDERR: loading of puppet_x/external_data/multiplexer failed, no external data will be returned172.17.0.2 - - - 12/Feb/2020:11:52:37 +0000 "GET /puppet/v3/file_content/plugins/puppet/parser/functions/chop.rb?environment=production& HTTP/1.1" 200 1343 172.17.0.2 172.17.0.2 8140 107
      2020-02-12 11:52:37,632 WARN  [c.p.p.ShellUtils] Executed an external process which logged to STDERR: loading of puppet_x/external_data/multiplexer failed, no external data will be returned172.17.0.2 - - - 12/Feb/2020:11:52:37 +0000 "GET /puppet/v3/file_content/plugins/puppet/parser/functions/clamp.rb?environment=production& HTTP/1.1" 200 1330 172.17.0.2 172.17.0.2 8140 84
      2020-02-12 11:52:37,730 WARN  [c.p.p.ShellUtils] Executed an external process which logged to STDERR: loading of puppet_x/external_data/multiplexer failed, no external data will be returned172.17.0.2 - - - 12/Feb/2020:11:52:37 +0000 "GET /puppet/v3/file_content/plugins/puppet/parser/functions/concat.rb?environment=production& HTTP/1.1" 200 1331 172.17.0.2 172.17.0.2 8140 85
      2020-02-12 11:52:37,811 WARN  [c.p.p.ShellUtils] Executed an external process which logged to STDERR: loading of puppet_x/external_data/multiplexer failed, no external data will be returned172.17.0.2 - - - 12/Feb/2020:11:52:37 +0000 "GET /puppet/v3/file_content/plugins/puppet/parser/functions/convert_base.rb?environment=production& HTTP/1.1" 200 1935 172.17.0.2 172.17.0.2 8140 87
      2020-02-12 11:52:37,916 WARN  [c.p.p.ShellUtils] Executed an external process which logged to STDERR: loading of puppet_x/external_data/multiplexer failed, no external data will be returned172.17.0.2 - - - 12/Feb/2020:11:52:37 +0000 "GET /puppet/v3/file_content/plugins/puppet/parser/functions/count.rb?environment=production& HTTP/1.1" 200 1373 172.17.0.2 172.17.0.2 8140 86
      2020-02-12 11:52:38,013 WARN  [c.p.p.ShellUtils] Executed an external process which logged to STDERR: loading of puppet_x/external_data/multiplexer failed, no external data will be returned172.17.0.2 - - - 12/Feb/2020:11:52:38 +0000 "GET /puppet/v3/file_content/plugins/puppet/parser/functions/create_ini_settings.rb?environment=production& HTTP/1.1" 200 1711 172.17.0.2 172.17.0.2 8140 94
      2020-02-12 11:52:38,107 WARN  [c.p.p.ShellUtils] Executed an external process which logged to STDERR: loading of puppet_x/external_data/multiplexer failed, no external data will be returned 

       

      Attachments

        Activity

          People

            Unassigned Unassigned
            dylan.ratcliffe Dylan Ratcliffe
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Zendesk Support