Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10316

Update http report processor to use http client

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 6.15.0
    • Component/s: None
    • Labels:
    • Template:
    • Acceptance Criteria:
      Hide

      When the http report processor receives a report, it should post the report to Puppet[:reporturl] using the new Puppet::HTTP::Client API. When using puppetserver, it should use the ExternalClient implementation created when puppetserver registered its http_client_class. When using puppet apply it should use the default Client implementation.

      The post request should include metric_id and if specified, user/password credentials for basic authentication.

      The post request should only trust the puppet PKI.

      The processor should receive a Puppet::HTTP::Response and may need to rescue Puppet::HTTP::HTTPError or subclasses.

      Show
      When the http report processor receives a report, it should post the report to Puppet [:reporturl] using the new Puppet::HTTP::Client API. When using puppetserver, it should use the ExternalClient implementation created when puppetserver registered its http_client_class. When using puppet apply it should use the default Client implementation. The post request should include metric_id and if specified, user/password credentials for basic authentication. The post request should only trust the puppet PKI. The processor should receive a Puppet::HTTP::Response and may need to rescue Puppet::HTTP::HTTPError or subclasses.
    • Epic Link:
    • Team:
      Coremunity
    • Sprint:
      Platform Core KANBAN
    • Release Notes:
      Enhancement
    • Release Notes Summary:
      The "http" report processor uses puppet's new HTTP client when running in the context of "puppet apply". When running in the context of puppetserver, it uses the existing HTTP client in puppetserver.
    • QA Risk Assessment:
      Needs Assessment

      Description

      The http report processor calls Puppet::Network::HttpPool to post the report to Puppet[:reporturl]. Modify the processor to use Puppet::HTTP::Client#post instead. It should continue to send the same query parameters, eg metric_idcontent-type, basic authentication, etc as it currently does. It should continue to only trust the puppet PKI.

      This is blocked on PUP-10324

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              josh Josh Cooper
              Reporter:
              josh Josh Cooper
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support