Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10434

Persistent http connection timeouts can't be changed when using the new http client

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 6.15.0
    • Component/s: None
    • Labels:
    • Template:
      PUP Bug Template
    • Team:
      Coremunity
    • Sprint:
      Platform Core KANBAN
    • Method Found:
      Needs Assessment
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Fixes a regression in 6.14.0 which caused puppet to cache persistent http connections for 15 seconds instead of the expected 4 seconds, and it was not possible to change the timeout using the Puppet[:http_keepalive_timeout] setting.
    • QA Risk Assessment:
      Needs Assessment

      Description

      The http client hardcodes the timeout for the http connection pool to 15 seconds. As a result, persistent connections can't be tuned or disabled. This issue existed when the client was created, but only noticed when most of puppet was switched over to use the client for network connections. To reproduce:

      $ puppet agent -td --http_keepalive_timeout 0 | grep 'Using cached connection'
      Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140
      Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140
      Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140
      Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140
      Debug: Using cached connection for https://bleak-scorecard.delivery.puppetlabs.net:8140
      

        Attachments

          Activity

            People

            Assignee:
            josh Josh Cooper
            Reporter:
            josh Josh Cooper
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support