Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10440

Remove networking code from the parent REST terminus

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • None
    • PUP 7.0.0
    • None
    • Bug Fix
    • Hide
      This is a breaking change for any REST terminus that relies on the parent REST terminus to perform the network request and process the response. REST termini must implement the find, search, save and destroy methods that make sense for their indirected model.
      Show
      This is a breaking change for any REST terminus that relies on the parent REST terminus to perform the network request and process the response. REST termini must implement the find, search, save and destroy methods that make sense for their indirected model.
    • Needs Assessment

    Description

      In 6.14.0, all of puppet's rest termini for a specific model, e.g. Puppet::Indirector::Catalog::Rest, use the http client to make REST requests. However, the abstract parent Puppet::Indirector::Rest still uses the legacy http code.

      This ticket is to have the parent's find, search, etc methods raise a NotImplementedError, and delete the supporting methods like headers, network, server, port, srv_service, etc

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. PUP-10439 Remove Puppet::Network::HTTP::ConnectionAdapter

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. PUP-10445 Add deprecation warning to find/search/save/destroy methods in the abstract rest terminus

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Task - A task that needs to be done. PUP-10441 Remove Puppet::Util::HttpProxy.request_with_redirects

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Activity

            People

              josh Josh Cooper
              josh Josh Cooper
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support