Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10653

Remove the Dir monkey-patch from Puppet if not used

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 7.0.0
    • Component/s: None
    • Template:
    • Team:
      Night's Watch
    • Story Points:
      2
    • Sprint:
      NW - 2020-09-16
    • Release Notes:
      Enhancement
    • Release Notes Summary:
      Remove external dependency on the win32/dir gem and replace the usage of CSIDL constants with environment variables
    • QA Risk Assessment:
      Needs Assessment

      Description

      We removed our external dependency on the win32-dir gem in PUP-6184 by pulling the gem code in puppet. However, it seems that win32-dir features are scarcely used outside of constants which can all be replaced by environment variables.

      We need to check if we're actually using anything from the dir monkey-patch. If not, we should remove it entirely.

        Attachments

          Activity

            People

            Assignee:
            gabriel.nagy Gabriel Nagy
            Reporter:
            gabriel.nagy Gabriel Nagy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support