Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10786

Puppet Node Clean action's LoggerIO needs to implement `warn`

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 7.0.0
    • Fix Version/s: PUP 7.1.0
    • Component/s: None
    • Labels:
    • Template:
      PUP Bug Template
    • Team:
      Froyo
    • Story Points:
      1
    • Sprint:
      Froyo - 11/23/2020
    • Method Found:
      Automated Test
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      A known issue with Puppet 7.0.0 was that the {{puppet node clean}} action would fail if the user was had their {{cadir}} in the legacy location or inside the {{ssldir}}. This was a regression and it no longer does so.
    • QA Risk Assessment:
      Needs Assessment

      Description

      In the Puppet Node face's 'clean' action, we load the Puppet Server CA CLI as a library, passing in a 'LoggerIO' object as an adapter between the CA's logging facilities and Puppet's.

      Previously, we only needed `inform` and `err` methods to call the relevant APIs in the CA - and it appears our LoggerIO adapter only implements those two methods.

      With the new cadir default change (see SERVER-2896) we may `warn` as well which will now cause puppet node clean calls to fail with an undefined method on LoggerIO.

      To fix this we should update the LoggerIO adapter to provide all the methods available in the Puppet Server CA's Logger.

        Attachments

          Activity

            People

            Assignee:
            justin Justin Stoller
            Reporter:
            justin Justin Stoller
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support