Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10924

`module install` can't unpack modules with long paths because of minitar bug

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • High
    • Resolution: Duplicate
    • PUP 7.3.0, PUP 6.21.1
    • None
    • None
    • None
    • Night's Watch
    • Needs Assessment
    • Needs Assessment

    Description

      Puppet Version: 6.21.1 but because of minitar 0.9 origins, likely also relevant to all other recent releases.
      OS Name/Version: xenial

      Trying to install modules with puppet module install when the module contains deeply nested paths fails with a minitar error.

      See https://github.com/puppetlabs/puppet-modulebuilder/pull/37 for the puppet-modulebuilder code changes to trigger this; See https://travis-ci.com/github/puppetlabs/puppet-modulebuilder/jobs/484161960#L423-L430 for the test results.

      Desired Behavior:

      Puppet should be able to install all valid modules.

      Actual Behavior:

      puppet module install fails with 

      Failed to install the module using Puppet. Exit code 1: Notice: Preparing to install into /tmp/d20210218-7106-kfle20 ...
      		 
      Error: "/1234567890" is not a valid octal string
      		 
      Error: Try 'puppet help module install' for usage

      josh would it make sense to move the unpack code also to puppet-modulebuilder to ease iterating and testing these connected code-paths? This gem is already used by voxpupuli/puppet-blacksmith and was slated to be used by the PDK (where this code was lifted from).

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. PDK-1684 PDK should support modules with long filenames

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. PA-3843 Make Windows Installer of Puppet Agent allow you to enable Long Filename Support (not enabled by default)

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. PUP-4854 PMT fails to install modules on Windows that have long paths

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PDK-1283 PDK fails to install dsc module from fixtures.yml on windows

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Task - A task that needs to be done. PA-3719 (spike) study long file names/long file paths support in 3rd party software and puppet

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. PUP-4866 Plugin Sync Should Use Long File Name (LFN) Paths on Windows

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PUP-8257 Puppet::FileSystem::Windows should support LFN

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Activity

            People

              Unassigned Unassigned
              david.schmitt David Schmitt
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support