Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10924

`module install` can't unpack modules with long paths because of minitar bug

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Accepted
    • Priority: High
    • Resolution: Unresolved
    • Affects Version/s: PUP 7.3.0, PUP 6.21.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:
      PUP Bug Template
    • Team:
      Night's Watch
    • Method Found:
      Needs Assessment
    • QA Risk Assessment:
      Needs Assessment

      Description

      Puppet Version: 6.21.1 but because of minitar 0.9 origins, likely also relevant to all other recent releases.
      OS Name/Version: xenial

      Trying to install modules with puppet module install when the module contains deeply nested paths fails with a minitar error.

      See https://github.com/puppetlabs/puppet-modulebuilder/pull/37 for the puppet-modulebuilder code changes to trigger this; See https://travis-ci.com/github/puppetlabs/puppet-modulebuilder/jobs/484161960#L423-L430 for the test results.

      Desired Behavior:

      Puppet should be able to install all valid modules.

      Actual Behavior:

      puppet module install fails with

      Failed to install the module using Puppet. Exit code 1: Notice: Preparing to install into /tmp/d20210218-7106-kfle20 ...
      Error: "/1234567890" is not a valid octal string
      Error: Try 'puppet help module install' for usage
      

      Josh Cooper would it make sense to move the unpack code also to puppet-modulebuilder to ease iterating and testing these connected code-paths? This gem is already used by voxpupuli/puppet-blacksmith and was slated to be used by the PDK (where this code was lifted from).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ciprian.badescu Ciprian Badescu
              Reporter:
              david.schmitt David Schmitt
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:

                  Zendesk Support