Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-10943

Windows package provider continues to read DisplayVersion key after embedded NULL

    XMLWordPrintable

    Details

    • Template:
      PUP Bug Template
    • Team:
      Night's Watch
    • Story Points:
      2
    • Sprint:
      NW - 2021-03-17
    • Method Found:
      Needs Assessment
    • Zendesk Ticket IDs:
      43253,44624
    • Zendesk Ticket Count:
      2
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      Before the fix some corrupted Windows registry could break puppet because puppet would not stop reading the registry at the correct WCHAR_NULL, and it continued to read bad data.
      Now, puppet only reads data until a WCHAR_NULL that is force encoded to UTF-16LE.
      Show
      Before the fix some corrupted Windows registry could break puppet because puppet would not stop reading the registry at the correct WCHAR_NULL, and it continued to read bad data. Now, puppet only reads data until a WCHAR_NULL that is force encoded to UTF-16LE.
    • QA Risk Assessment:
      Needs Assessment

      Description

      When scanning for existing packages in Windows, Puppet reads uninstall listings in the "per-machine" and "current user" contexts, both 32 and 64 bit using the DisplayName or, more rarely, the QuietDisplayName keys. If these keys have an embedded Null, the package provider continues to read garbage data. It may attempt to decode these junk characters from UTF-16LE and fail.

      An update was pushed out to fix this (PUP-10536), but a customer recently hit the bug again. This is a followup to that ticket.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dorin.pleava Dorin Pleava
              Reporter:
              miranda.streeter Miranda Streeter
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support