Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-11311

Reduce memory usage from Pathname absolute?

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • None
    • PUP 7.13.0
    • None
    • Coremunity
    • Coremunity Kanban
    • Needs Assessment
    • Bug Fix
    • Backported ruby patch to Pathname.absolute? to reduce memory usage
    • Needs Assessment

    Description

      Pathname.absolute?('/a/b/c/etc') makes recursively smaller copies of the path, e.g. '/a/b/c', '/a/b', '/a', '', which leads to excessive numbers of temporary strings. Pathname was fixed upstream and that was included in ruby 3.0, but it would be good to apply the same to our 2.x builds:

      See https://github.com/ruby/ruby/commit/39312cf4d6c2ab3f07d688ad1a467c8f84b58db0

       

      Attachments

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. PUP-6585 Remove internal usage of Puppet::Util.absolute_path?(path) / replace with Pathname.new(path)

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Activity

            People

              josh Josh Cooper
              josh Josh Cooper
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support