Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-1723

Yumrepo logs info messages without context

    XMLWordPrintable

    Details

    • Template:
    • Team:
      Agent
    • Story Points:
      1
    • Sprint:
      Agent 2017-05-31
    • Release Notes:
      Bug Fix
    • Release Notes Summary:
      Hide
      The yumrepo provider will now include context information when changing the mode of a repo file, e.g.

      {noformat}
      Info: Yumrepo[IUS](provider=inifile): changing mode of
      /etc/yum.repos.d/puppet-agent.repo from 600 to 644
      {noformat}
      Show
      The yumrepo provider will now include context information when changing the mode of a repo file, e.g. {noformat} Info: Yumrepo[IUS](provider=inifile): changing mode of /etc/yum.repos.d/puppet-agent.repo from 600 to 644 {noformat}
    • QA Risk Assessment:
      Manual

      Description

      Since PUP-789, the yumrepo inifile provider logs two messages without any context (e.g. the resource or provider).

      create new repo SCL in file /etc/yum.repos.d/SCL.repo
      /Stage[main]/Foreman::Install::Repos::Extra/Yumrepo[SCL]/ensure: created
      changing mode of /etc/yum.repos.d/SCL.repo from 600 to 644
      

      The provider code calls "Puppet.info" currently when it should use just "info" to add context. As these are class utility methods, it should ideally use the context from the instance to provide even better context, related to the resource that made the change.

        Attachments

          Activity

            People

            Assignee:
            qa qa
            Reporter:
            domcleal Dominic Cleal
            QA Contact:
            Narmadha Perumal
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support