Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-1763

Puppet run continues despite failed Pluginsync

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • PUP 3.4.3
    • PUP 5.5.22, PUP 6.18.0
    • None

    • RHEL6

    • Bug Fix
    • Hide
      Previously, puppet agents ignored pluginsync errors and would apply the catalog with possibly incorrect facts and plugin versions, leading to obscure errors or data corruption. This release adds a new setting `ignore_plugin_errors`. If set to false, then the agent will abort the run if pluginsync fails. The setting defaults to true so the old behavior is preserved. In Puppet 7, the default value will be switched to false.
      Show
      Previously, puppet agents ignored pluginsync errors and would apply the catalog with possibly incorrect facts and plugin versions, leading to obscure errors or data corruption. This release adds a new setting `ignore_plugin_errors`. If set to false, then the agent will abort the run if pluginsync fails. The setting defaults to true so the old behavior is preserved. In Puppet 7, the default value will be switched to false.

    Description

      A puppet run that has enough custom types/providers/facts to sync to a local system that it exceeds configtimeout (default 2m), should not continue to perform a puppet run, but rather completely fail. This would be the only way to meet the expectation that pluginsync ensures certain types/providers/facts are available before a module's code runs.

      If a puppetrun can continue despite failing to download plugins or custom facts, the proper operation of puppet modules cannot be guaranteed (without sanity checks in the puppet code). Also, it becomes impossible to base a Hiera hierarchy off of a custom fact because the first run would fail to pull in the expected Hiera data.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. PUP-10598 Change default value of ignore_plugin_errors to false

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. PUP-2608 An error is logged during an agent run if the puppetmaster does not have at least one <module>/lib dir in its modules directory.

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. PUP-7456 When agent gets its environment set by an ENC and cannot connect to the master it will pluginsync from the production environment ( possibly removing custom facts, etc... )

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed
          relates to

          Task - A task that needs to be done. PUP-10598 Change default value of ignore_plugin_errors to false

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. PUP-10667 if pluginsync fails puppet should apply cached catalog

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. PUP-2885 Periodic timeouts when reading from master

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. PUP-10582 Puppet runs should fail fast when no environment can be found

          • Normal - Regular issue, some loss of functionality under specific circumstances.
          • Closed

          Activity

            People

              josh Josh Cooper
              wvl0 William Leese
              Votes:
              4 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support