Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-2339

ci-bootstrap-from-artifacts.sh should fall-back to public Rubygems

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 3.6.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Week 2014-5-7 to 2014-5-14

      Description

      If $GEM_SOURCE is not set by the Jenkins job, ci-bootstrap-from-artifacts.sh sets it to our internal Rubygems mirror. This is not a safe assumption. If our internal mirror is down, we need to be able to disable it easily. Furthermore, if the hostname changes, we should be updating Jenkins jobs en masse, not hard-coded values in scripts in each of our repos. The authority for Rubygems should always be rubygems.org, and we should override it via the environment.

      In the script ci-bootstrap-from-artifacts.sh, replace:

      if [ -z $GEM_SOURCE ]; then
        export GEM_SOURCE='http://rubygems.delivery.puppetlabs.net'
      fi
      

      with

      if [ -z $GEM_SOURCE ]; then
        export GEM_SOURCE='https://rubygems.org'
      fi
      

      This would make the logic in the bootstrap script equivalent to how we set the source in Gemfile:

      source ENV['GEM_SOURCE'] || "https://rubygems.org"
      

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            roger Roger Ignazio
            QA Contact:
            Kurt Wall Kurt Wall
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support