Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-2733

Puppet squats on the PuppetX::Puppetlabs and PuppetX::Puppet namespaces

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: PUP 3.5.0
    • Fix Version/s: PUP 4.0.0
    • Component/s: None
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      Platform Server 2014-11-12, Platform Server 2014-11-26

      Description

      The implementation of the heredoc syntax validators added logic into the PuppetX module, took the names PuppetX::Puppetlabs and PuppetX::Puppet and added an implementation into PuppetX::Puppetlabs for json syntax validation and some interfaces into PuppetX::Puppet.

      The PuppetX module needs to remain as a convention for code external to puppet to have for any implementations outside of the implementation of the extension itself (e.g. Puppet::Type::X) to use. By adding logic to the PuppetX ruby module, we have begun interfering with extensions.

      The use of PuppetX::Puppet is a little less of a problem, but seems to be very strange that puppet is extending itself. Puppet code should be contained within Puppet, not PuppetX.

      I would expect that Puppet would have no meaningful contact with PuppetX other than, maybe, creating the PuppetX ruby module in puppetx.rb.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  andy Andrew Parker
                  QA Contact:
                  Kurt Wall
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Zendesk Support