Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-2752

Module tool fails to install new modules if some existing modules version is not Major.Minor.Patch format

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: PUP 3.6.0, PUP 3.6.1, PUP 3.6.2
    • Fix Version/s: PUP 3.7.0
    • Component/s: PMT
    • Labels:
    • Template:
    • Story Points:
      3
    • Sprint:
      Week 2014-6-25 to 2014-7-9, 2014-07-23, 2014-08-06

      Description

      Since Puppet 3.6.0 the module tool is unable to install new modules if an already existing modules version does not conform to the MAJOR.MINOR.PATCH format.

      I believe this behaviour was introduced with the dependency resolver ( https://github.com/puppetlabs/puppet/commit/6fa68b54ac621d60dbf1b062f8dd66b186d1a87f )

      How to reproduce problem:

      • Place a module that does not conform with the X.Y.Z version format in your module folder (e.g. https://github.com/mrintegrity/puppet-pound ). To simulate this with another module just edit the metadata.json accordingly.
      • Try to install another module

        % grep version modules/pound/metadata.json 
          "version": "0.1",
        % puppet module --modulepath /some/path/to/your/puppet/modules install --version=2.0.1 --ignore-dependencies saz/rsyslog
        Notice: Preparing to install into /some/path/to/your/puppet/modules ...
        Error: Version numbers MUST begin with three dot-separated numbers
        Error: Try 'puppet help module install' for usage
        %
        

      What I would expect:

      • Only check the version of modules the new module depends on
      • Make it a warning instead of an error to avoid breaking existing setups
      • Output which modules version does not conform the the correct format (to avoid thinking the module being installed is at fault)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                anderson Anderson Mills
                Reporter:
                fadenb Tristan Helmich
                QA Contact:
                John Duarte
              • Votes:
                2 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support