Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-2892

Debian init scripts do not support a custom DAEMON location

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: PUP 3.6.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Template:

      Description

      The init scripts that are provided for debian for both puppet and puppetmaster (ext/debian/puppet.init and ext/debian/puppetmaster.init) both share a problem: they check for the existence of $DAEMON before including the defaults file.

      As such, it is impossible to use a custom $DAEMON location by configuring it in the defaults file.

      This can be trivially fixed in both places by reversing the order of the $DAEMON executable test and the inclusion of the defaults file.

      i.e. for puppet.init, instead of:

      test -x $DAEMON || exit 0
       
      [ -r /etc/default/puppet ] && . /etc/default/puppet
      

      ... reorder to include the defaults file first:

      [ -r /etc/default/puppet ] && . /etc/default/puppet
       
      test -x $DAEMON || exit 0
      

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            remi.broemeling Remi Broemeling
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Zendesk Support