Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-3056

Restore constants / deprecated call sites changed during x64 upgrade that impact ACL module

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Major
          • Resolution: Fixed
          • Affects Version/s: PUP 3.6.2
          • Fix Version/s: PUP 3.7.0
          • Component/s: None
          • Labels:
          • Template:
          • Epic Link:
          • Story Points:
            1
          • Sprint:
            2014-08-20

            Description

            When Puppet::Util::Windows::File and Puppet::Util::Windows::Security were refactored, mixins from older versions of the {{windows-pr]} gem were removed.

            At the time, we didn't check downstream modules to see if they were consuming any of the mixed in methods or constants.

            A scan through the ACL module has revealed that some methods were not properly redirected with deprecation messages. Furthermore, a few necessary constants were either moved, or not restored to the classes that were originally mixed into.

            Constants that need to be restored are

            GENERIC_WRITE
            		 
            GENERIC_EXECUTE
            		 
            GENERIC_ALL
            		 
             
            		 
            DELETE

            The list of redirections includes

              Puppet::Util::ADSI::User -> Puppet::Util::Windows::ADSI::User
            		 
             
            		 
              Windows::File::FILE_ALL_ACCESS -> Puppet::Util::Windows::File::FILE_ALL_ACCESS
            		 
              Windows::File::FILE_EXECUTE -> Puppet::Util::Windows::File::FILE_EXECUTE
            		 
              Windows::File::FILE_GENERIC_WRITE -> Puppet::Util::Windows::File::FILE_GENERIC_WRITE
            		 
              Windows::File::FILE_GENERIC_READ -> Puppet::Util::Windows::File::FILE_GENERIC_READ
            		 
              Windows::File::FILE_GENERIC_EXECUTE -> ?? Puppet::Util::Windows::File::FILE_GENERIC_EXECUTE
            		 
              Windows::File::FILE_WRITE_DATA -> Puppet::Util::Windows::File::FILE_WRITE_DATA
            		 
              Windows::File::FILE_WRITE_ATTRIBUTES -> Puppet::Util::Windows::File::FILE_WRITE_ATTRIBUTES
            		 
              Windows::File::FILE_READ_DATA  -> Puppet::Util::Windows::File::FILE_READ_DATA
            		 
              Windows::File::FILE_APPEND_DATA -> Puppet::Util::Windows::File::FILE_APPEND_DATA
            		 
             
            		 
              Windows::File::GENERIC_ALL -> Puppet::Util::Windows::File::GENERIC_ALL
            		 
              Windows::File::GENERIC_WRITE -> Puppet::Util::Windows::File::GENERIC_WRITE
            		 
              Windows::File::GENERIC_READ -> Puppet::Util::Windows::File::GENERIC_READ
            		 
              Windows::File::GENERIC_EXECUTE -> Puppet::Util::Windows::File::GENERIC_EXECUTE
            		 
              
              Windows::File::READ_CONTROL -> Puppet::Util::Windows::Security::READ_CONTROL
            		 
              
              Windows::File::DELETE -> Puppet::Util::Windows::Security::DELETE
            		 
             
            		 
              Windows::Security::GENERIC_ALL -> Puppet::Util::Windows::File::GENERIC_ALL
            		 
              
              Puppet::Util::Windows::Security.valid_sid?() -> Puppet::Util::Windows::SID.valid_sid?()
            		 
              Puppet::Util::Windows::Security.name_to_sid() -> Puppet::Util::Windows::SID.name_to_sid()
            		 
              Puppet::Util::Windows::Security.sid_to_name() -> Puppet::Util::Windows::SID.sid_to_name()

              Attachments

                Issue Links

                relates to

                Epic - Created by JIRA Software - do not edit or delete. Issue type for a big user story that needs to be broken down. PUP-2396 Support ruby 2.0 x64 on windows

                • Normal - Regular issue, some loss of functionality under specific circumstances.
                • Closed

                Bug - A problem which impairs or prevents the functions of the product. MODULES-1174 Puppetlabs-Acl may break on Puppet 3.7.0

                • Normal - Regular issue, some loss of functionality under specific circumstances.
                • Resolved
                links to

                Web Link Puppet master PR #2967

                  Activity

                    People

                    • Assignee:
                      Unassigned
                      Reporter:
                      ethan Ethan Brown
                      QA Contact:
                      Erik Dasher
                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      2 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:

                        Zendesk Support