Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Won't Fix
-
None
-
None
-
Debian sid (workstation used for testing)
rbenv with Rubies 2.0.0-p353, 1.9.3-p194, 1.8.7-p352 and 1.8.7-p302
Description
https://github.com/puppetlabs/puppet/commit/baee7126eca089adc894e8ae7232fc3eb698f0c7 introduced a syntax error in the test suite on older Ruby 1.8.7 versions. I've confirmed failure on 1.8.7-p352 and 1.8.7-p302, although it seems to have passed on 1.8.7-p374 on Travis.
The problem is that older Rubies don't know that this is a single logical line of code, and need the newline to be escaped:
expect(PSON.parse(text))
.to eq({"data" => {}, "document_type" => "Node"})
I'm not sure whether this is worth filing a ticket for, but CONTRIBUTING.md requests that commit messages reference a bug number, which is why I'm putting this into Jira. I'll be submitting a trivial pull request shortly.