Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-3470

Syntax error in test suite on Ruby <= 1.8.7-p352

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: PUP 4.0.0
    • Component/s: None
    • Labels:
    • Environment:

      Debian sid (workstation used for testing)
      rbenv with Rubies 2.0.0-p353, 1.9.3-p194, 1.8.7-p352 and 1.8.7-p302

    • Template:

      Description

      https://github.com/puppetlabs/puppet/commit/baee7126eca089adc894e8ae7232fc3eb698f0c7 introduced a syntax error in the test suite on older Ruby 1.8.7 versions. I've confirmed failure on 1.8.7-p352 and 1.8.7-p302, although it seems to have passed on 1.8.7-p374 on Travis.

      The problem is that older Rubies don't know that this is a single logical line of code, and need the newline to be escaped:

      expect(PSON.parse(text))
      .to eq({"data" => {}, "document_type" => "Node"})

      I'm not sure whether this is worth filing a ticket for, but CONTRIBUTING.md requests that commit messages reference a bug number, which is why I'm putting this into Jira. I'll be submitting a trivial pull request shortly.

        Attachments

          Issue Links

            Activity

              jsd-sla-details-panel

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  anchor Anchor
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: