Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-3482

server-side only execution stub

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Accepted
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: PUP 5.y
    • Component/s: None
    • Labels:
      None
    • Template:
    • Epic Link:
    • Team:
      Coremunity

      Description

      In puppet-server, we install an 'execution stub' into puppet. The reason for this is that, when no execution stub has been installed, Puppet::Util::Execution.execute eventually ends up calling Kernel.fork to run the command, and Kernel.fork is not available on JRuby.

      Puppet::Util::Execution.execute takes a second parameter which is a set of options to be used when executing the command. The execution stub used by puppet-server does not support any of these options, for a couple of reasons:

      • we haven't had time to implement them, but more importantly ...
      • it seems like most of them are really only relevant when running an external command on an agent host, not the master.

      To avoid unnecessarily implementing support for all of those options in puppet-server's execution stub, we would like to change Puppet::Util::Execution.execute to be marked as a agent-side only API, and introduce a new method for use on the server side. This was the conclusion of a discussion with Eric Sorenson.

      To wrap this up, we would need to:

      Another little bit of info: I grepped through the forge to look for usages of Puppet::Util::Execution.execute, and didn't find any - so, while this is technically an API-breaking change on the server-side, it seems like it would be low-impact.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              kevin.corcoran Kevin Corcoran
              QA Contact:
              Erik Dasher
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Zendesk Support