Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-3512

Require metric id in Puppet Profiler API

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.0.0
    • Component/s: None
    • Labels:
      None

      Description

      This ticket should move to PUP when we have a "Green Team" component over there.

      The "Profiler" API in Puppet used to only require a single string to be passed in as the identifier for a profiling block, and this would be part of the log message. Since then we've added a metric ID composed of an array of strings (namespace + metric name), which allows us to do much more interesting things with the metrics. However, we left in support for the old profiling API because there were some external projects (PuppetDB) using the old syntax... need to deprecate or remove it.

      UPDATED:

      After discussion it was determined that the best solution was to simply move forward with the new API, where the metric_id field is required. This change was shipped (I believe) in Puppet 3.7.3.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                chris Chris Price
                QA Contact:
                Erik Dasher
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: