Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-3551

Sanitize non-UTF-8 data in run reports

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Ready for Engineering
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: PUP 5.y
    • Component/s: None
    • Labels:
      None
    • Template:
    • Acceptance Criteria:
      • If invalid UTF-8 characters are in a report, we replace those with Unicode replacement characters and always send the report.
    • Team:
      Coremunity
    • Story Points:
      3
    • Sprint:
      Agent 2017-06-14, Agent 2017-06-28

      Description

      One of the consequences of using JSON and the existing serialization of reports is that it won't be able to handle non-UTF-8 showing up. Non-UTF-8 data would not show up from the catalog information (since it also has the same UTF-8 restriction), but it can show up in the output of the commands that puppet runs as part of applying a catalog.

      Puppet must be able to send the report about the run. It can't be stopped by some data that prevents a particular serialization mechanism from working correctly. In order to send the report puppet should strip any non-UTF-8 sequences in the report and replace them with something that can be serialized.

      In Scope

      • Investigate use of replacement characters for invalid UTF-8 byte sequences in report data where applicable
      • Ensure that report is sent (or at least is not hindered by non-UTF-8 data)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              andy Andrew Parker
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:

                  Zendesk Support