Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-3830

Automatic quoting of install_options breaks NullSoft installation directory parameter

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Windows
    • Labels:
    • Template:

      Description

      From http://nsis.sourceforge.net/Which_command_line_parameters_can_be_used_to_configure_installers:

      <pre>
      *Options*

      • /D=C:\Bla or /D=C:\Path with spaces
        • Set installation folder ($INSTDIR)
        • Must be the last parameter on the command line and must not contain quotes even if the path contains blank spaces.
        • Related to: $INSTDIR

      </pre>

      From: http://docs.puppetlabs.com/references/latest/type.html
      <blockquote>
      *windows*
      Windows package management.
      This provider supports either MSI or self-extracting executable installers.

      This provider requires a source attribute when installing the package. It accepts paths paths to local files, mapped drives, or UNC paths.

      If the executable requires special arguments to perform a silent install or uninstall, then the appropriate arguments should be specified using the install_options or uninstall_options attributes, respectively. Puppet will automatically quote any option that contains spaces.
      </blockquote>

      The problem is NullSoft installer doesn't work right when the /D option contains quotes. Also it is required to be at the end, so you can't get cute and shift it in between two other arguments that blobbed together as a single string. In order to be able to install NullSoft packages to non-default paths with spaces, there needs to be some way to disable the auto quoting.

        Attachments

          Activity

            jsd-sla-details-panel

              People

              • Assignee:
                Unassigned
                Reporter:
                redmine.exporter redmine.exporter
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: