Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-3951

Prefer api_types.read_wide_str(length, encoding) in Windows calls

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.0.0
    • Component/s: Windows
    • Labels:
    • Template:
    • Story Points:
      2
    • Sprint:
      Windows 2015-02-11

      Description

      The following sections of code call read_wide_string() without passing an encoding, leaving it up to the the method to select Encoding.default_external as the encoding for these sections. This is generally okay in most cases but the areas should be reviewed to determine if we should instead be passing Encoding::UTF_8, as we are doing with lib/puppet/util/windows/registry.rb as of PUP-3837.

      • ADSI.self.computername - adsi.rb:44
      • User.current_user_name adsi.rb:240
      • Error.format_error_code error.rb:51
      • File.resolve_symlink file.rb:285
        And make sure all of them come back correctly with weird default external encodings?

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              rob Rob Reynolds
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Zendesk Support