[PUP-3970] Puppet::Util::Windows::String.wide_string should not embed a NULL char - Puppet Jira Server

XML

Word

Printable

Details

Type: Task
Status: Resolved
Priority: Normal
Resolution: Fixed
Affects Version/s: PUP 4.0.0
Fix Version/s: PUP 7.0.0
Component/s: Windows
Labels:
- doc_reviewed
- windows

Team:
Coremunity
Story Points:
1
Sprint:
Platform Core KANBAN

Release Notes:
Bug Fix
Release Notes Summary:
Remove Ruby workaround for wide character strings on Windows

Description

puppet/util/windows/string.rb currently contains some code intended to work around Ruby bugs prior to 2.1

This code should now be moot, but requires some validation \ verification.

Current callsites include:

https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/file.rb
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/process.rb
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/api_types.rb#L25
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/security.rb
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/taskscheduler.rb
https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/user.rb
https://github.com/puppetlabs/puppet/blob/master/spec/unit/util/windows/string_spec.rb

Make sure any module usage is monitored as well.

Attachments

Issue Links

is blocked by

PUP-10254 Ensure Windows wide character strings have a wide terminator

Closed

relates to

PA-476 Update puppet-agent to use Ruby 2.4

Closed

IAC-967 puppetlabs-motd: Determine root cause of missing chars / additional newline in reg values using Puppet 7

Resolved

PUP-10602 Registry key values being truncated or superfluous newline present

Resolved

PUP-3776 Upgrade Windows Ruby to 2.1.5

Closed

mentioned in: Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...

(5 mentioned in)

Activity

People

Assignee:: Josh Cooper

Reporter:: Ethan Brown

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2015/02/05 3:24 PM

Updated:: 2020/11/10 2:43 AM

Resolved:: 2020/07/24 4:11 PM

Zendesk Support