Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4009

Add Cfacter 0.4.0 to Windows MSI

    Details

    • Type: Task
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 4.0.0
    • Component/s: Windows
    • Labels:

      Description

      CFacter 0.3.0 is the current version that we're bundling with the MSI. However, this version has a number of issues that prevent it from working properly on Windows, and therefore to be able to use cfacter with external facts (CFACT-219), custom facts, on Windows 2003 (CFACT-166) and inside puppet itself via the --cfacter switch (CFACT-198 / PUP-3821 / CFACT-208), we must ship the fully released CFacter 0.4.0.

      Note that there were also a number of change made to puppet_for_the_win to allow CFacter to be used, including PUP-3854 and https://github.com/puppetlabs/puppet_for_the_win/pull/91. cfacter.rb needs to be in the appropriate cfacter/lib directory for Puppet to be able to call it.

      With that said, ext/build_defaults.yaml should have not only the cfacter reference at https://github.com/puppetlabs/puppet/blob/master/ext/build_defaults.yaml#L25-L28 changed, but also the puppet_for_the_win ref at https://github.com/puppetlabs/puppet/blob/master/ext/build_defaults.yaml#L20

      At the same time, the foss-4.0-x86.yaml and foss-4.0-x64.yaml should be updated as well:

      https://github.com/puppetlabs/puppet_for_the_win/blob/master/foss-4.0-x64.yaml
      https://github.com/puppetlabs/puppet_for_the_win/blob/master/foss-4.0-x86.yaml

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              ethan Ethan Brown
              QA Contact:
              Ryan Gard
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Zendesk Support