Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-4030

Add support for no_proxy env var

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Normal
    • Resolution: Fixed
    • None
    • PUP 4.2.0
    • None
    • None
    • RHEL 6 (x86_64)
    • 1
    • Client 2015-05-13
    • New Feature
    • Hide
      This change allows puppet to respect the no_proxy ENV var when set on the system. Previously, Puppet would respect the http(s)_proxy ENV var when connecting HTTP services (e.g. puppet forge) but ignore the no_proxy setting.

      Documentation is a bit inconsistent with regards to specifying domain level exception. WGET docs for example, state that the no_proxy list should be of suffixes and thus an entry with a preceding '.' (e.g. .example.com) creates an exception for any host under that domain. Curl man pages and other internet resources, suggest the use of a '*' as a wildcard.

      This change supports both notations.
      Show
      This change allows puppet to respect the no_proxy ENV var when set on the system. Previously, Puppet would respect the http(s)_proxy ENV var when connecting HTTP services (e.g. puppet forge) but ignore the no_proxy setting. Documentation is a bit inconsistent with regards to specifying domain level exception. WGET docs for example, state that the no_proxy list should be of suffixes and thus an entry with a preceding '.' (e.g. .example.com) creates an exception for any host under that domain. Curl man pages and other internet resources, suggest the use of a '*' as a wildcard. This change supports both notations.

    Description

      Puppet::Util::HttpProxy returns a proxy object to use for interacting with the forge in the case that http_proxy is set. However, it does not take into account the no_proxy variable meaning that it will always use the proxy even if no_proxy would have it go direct.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              chrisportman Chris Portman
              Eric Thompson Eric Thompson
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Zendesk Support