Uploaded image for project: 'Puppet'
  1. Puppet
  2. PUP-406

Deprecate stringify_fact = true

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: PUP 3.7.0
    • Component/s: DOCS
    • Labels:
      None
    • Template:
    • Story Points:
      1
    • Sprint:
      2014-08-06, 2014-09-03

      Description

      Erik Dalen's patch that allows turning off the stringification of facts by puppet opens the door to structured facts. In 3.x that settings was to still stringify by default, in 4.0.0 it needs to be changed to not stringify by default and to issue a deprecation warning when it is set to stringify.

      The reason for the deprecation and not complete removal is to provide an upgrade path in case not stringifying causes some errors for some users.

        Attachments

          Issue Links

            Activity

            Hide
            andy Andrew Parker added a comment -

            Should this be deprecated in 4 or should this happen in 3.6? Since Facter 2 is going out soon, it seems like deprecating this in 3.6 might be something to push forward on structured facts more quickly.

            Show
            andy Andrew Parker added a comment - Should this be deprecated in 4 or should this happen in 3.6? Since Facter 2 is going out soon, it seems like deprecating this in 3.6 might be something to push forward on structured facts more quickly.
            Hide
            kylo Kylo Ginsberg added a comment -

            This will be deprecated in docs, but won't produce a deprecation warning.

            Show
            kylo Kylo Ginsberg added a comment - This will be deprecated in docs, but won't produce a deprecation warning.
            Hide
            nick.fagerlund Nicholas Fagerlund added a comment -

            Kylo Ginsberg Does that mean it won't issue a deprecation warning on 4.0? Can / should we update the setting description with a deprecation note NOW, for 3.7?

            Show
            nick.fagerlund Nicholas Fagerlund added a comment - Kylo Ginsberg Does that mean it won't issue a deprecation warning on 4.0? Can / should we update the setting description with a deprecation note NOW, for 3.7?
            Hide
            nick.fagerlund Nicholas Fagerlund added a comment -

            The description of the setting in lib/puppet/defaults.rb should be edited to add a deprecation note re: the default value.

            Show
            nick.fagerlund Nicholas Fagerlund added a comment - The description of the setting in lib/puppet/defaults.rb should be edited to add a deprecation note re: the default value.
            Hide
            kylo Kylo Ginsberg added a comment -

            Merged to master in 49dd1ec1 to be released in 3.7.0.

            Show
            kylo Kylo Ginsberg added a comment - Merged to master in 49dd1ec1 to be released in 3.7.0.
            Hide
            kylo Kylo Ginsberg added a comment -

            No FR needed. Docs only and Nick gave it a thumbs-up.

            Show
            kylo Kylo Ginsberg added a comment - No FR needed. Docs only and Nick gave it a thumbs-up.

              People

              • Assignee:
                Unassigned
                Reporter:
                andy Andrew Parker
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Zendesk Support